dvd::rip

->ABOUT / NEWS

->DOCUMENTATION
-TABLE OF CONTENTS
-INSTALLATION
-USING THE GUI
-CLUSTER MODE
-FAQ

->KEY FEATURES

->DOWNLOAD

->SUPPORT

->TRANSLATIONS

->MAILING LIST
-SEARCH ARCHIVE

->CHANGE LOG

->CREDITS

->TODO

->LINKS

http://www.exit1.org/


Re: [dvd::rip] Wrong title being transcoded

Subject: Re: [dvd::rip] Wrong title being transcoded
From: Jörn Reder <joern@xxxxxx>
Date: Tue, 30 Jan 2007 16:13:38 +0100
"Ezequiel Valenzuela" wrote:

> I've been using transcode for a few good years now, and I'm generally
> happy with it :)

Thanks, as well for the extensive bug-report.

> $ dvdrip -f transcode -t 4 ../projects/myproject.rip
> 
> === log file === ->
> 
> Tue Jan 30 11:33:49 2007        Detected transcode version: 10002
> Tue Jan 30 11:33:49 2007        Selecting title 4
> Tue Jan 30 11:33:49 2007        Start job 'Transcode - title #5'

Ups, looks like an ugly n-1 bug here. Obviously dvd::rip adds one to the
given title number, where it should not (resp. it misses decrementing it
;)

> There's another thing that "stopped" working: automatically closing the
> project and ending the (dvdrip) process once transcoding for the
> specified title has finished. Hence, I have to manually close down the
> program for the next title to be transcoded (I usually prepare several
> titles and then use a "for .. do .. done" block to trigger transcoding
> of all the titles at once).

Ups, there was a "not implemented yet" warning instead of an 
implementation.

> I'm not sure whether this issue would go away by downgrading or not, and
> I'm a little bit worried that loading project files with previous
> versions of the program would generate dodgy/unexpected results and/or
> corrupt the project file.

Downgrading is not recommended if you like to use your project files. 
Probably it works, but it's not bullet-proof-tested ;)

> Did anyone experience something (remotely) similar to this? Any ideas on
> how to fix it?

Please apply the attached patch. It's not tested yet (I'm not at my home
workstation), but there are good chances that it will work, because it's
simple ;). Please report whether it solves your problems.

Regards,

Jörn

-- 
Joern Reder
supporting:   http://www.zyn.de/
unbelievable: http://www.exit1.org/
CPAN:         http://www.perl.com/CPAN/modules/by-authors/id/J/JR/JRED
Index: GUI/ExecFlow.pm
===================================================================
RCS file: /home/cvsroot/dvdrip/lib/Video/DVDRip/GUI/ExecFlow.pm,v
retrieving revision 1.7
diff -u -r1.7 ExecFlow.pm
--- GUI/ExecFlow.pm     18 Aug 2006 21:23:13 -0000      1.7
+++ GUI/ExecFlow.pm     30 Jan 2007 15:09:18 -0000
@@ -226,7 +226,7 @@
 sub signal_program_exit {
     my $self = shift;
 
-    warn "signal_program_exit() not implemented yet";
+    $self->get_context->get_object("main")->exit_program (force => 1);
     
     1;    
 }
Index: GUI/Main.pm
===================================================================
RCS file: /home/cvsroot/dvdrip/lib/Video/DVDRip/GUI/Main.pm,v
retrieving revision 1.91
diff -u -r1.91 Main.pm
--- GUI/Main.pm 25 Aug 2006 16:48:14 -0000      1.91
+++ GUI/Main.pm 30 Jan 2007 15:09:18 -0000
@@ -145,7 +145,7 @@
                     $self->log("Selecting title $select_title");
                     $context->set_object_attr( "content.selected_title_nr",
                         $select_title );
-                    $project->content->set_selected_titles( [$select_title] );
+                    $project->content->set_selected_title_nr($select_title);
                 }
 
                 # Execute a function, if requested

Attachment: pgpC7dLRm30O0.pgp
Description: PGP signature

<Prev in Thread] Current Thread [Next in Thread>
 

Archive powered by MHonArc. Search powered by ht://dig.

[ top ]