Re: [dvd::rip] dvd::rip 0.98.4 / 0.98.6 failures

Juan RP wrote:

> Looks like that it fails because my ffmpeg doesn't know about -vframes.
> 
> tc_memcpy: using amd64 for memcpy
> ffmpeg version 0.4.9-pre1, build 4718,

Yes, your ffmpeg is too old. Unfortunately they didn't spend official 
version numbers after 0.4.9-pre1, so it's difficult to do an explicit 
ffmpeg version check to workaround this resp. to fall back to pure 
transcode based preview grabbing in that case.

Anyhow, I did my best, please try the attached patch.

Regards,

Jörn

-- 
Think before you code. And while you're doing it probably won't hurt. ;)

Index: lib/Video/DVDRip/Depend.pm
===================================================================
RCS file: /home/cvsroot/dvdrip/lib/Video/DVDRip/Depend.pm,v
retrieving revision 1.22.2.7
diff -u -r1.22.2.7 Depend.pm
--- lib/Video/DVDRip/Depend.pm  14 Apr 2007 14:38:42 -0000      1.22.2.7
+++ lib/Video/DVDRip/Depend.pm  18 Apr 2007 08:12:17 -0000
@@ -107,14 +107,14 @@
         command     => "ffmpeg",
         comment     => __ "FFmpeg video converter command line program",
         optional    => 1,
-        version_cmd => "ffmpeg --version",
+        version_cmd => "ffmpeg -version",
         get_version => sub {
             my ($cmd) = @_;
             qx[$cmd 2>&1] =~ /version ([^\s]+)/i;
             return $1;
         },
         convert       => 'default',
-        min           => "0",
+        min           => "0.4.10",
     },
     xvid4conf => {
         order       => ++$ORDER,
@@ -293,7 +293,7 @@
 
 sub convert_default {
     my ($ver) = @_;
-    return 990000 if $ver eq 'cvs';
+    return 990000 if $ver =~ /cvs|svn/i;
     $ver =~ m/(\d+)(\.(\d+))?(\.(\d+))?(\.\d+)?/;
     $ver = $1 * 10000 + $3 * 100 + $5;
     $ver = $ver - 1 + $6 if $6;

pgpFnuFTPquTz.pgp
Description: PGP signature