Re: [dvd::rip] Patch: add "auto clip only" as a zoom/clip preset

[Marc Sherman <msherman@xxxxxxxxxxxxx>]

Jörn Reder wrote:
> You are right, but I was too lazy in the first approach ;) There *are* 
> different DVD resolutions possible, would be better to calculate the 
> exact factor to be sure.
>
> Attached you find a patch (against vanilla 0.98.8) accomplishing this. 
> As well the --export_par parameter is now calculated during internal 
> transcode command generation instead of adding it visibly to the 
> transcode options field. You still can set --export_par there to overide
> dvd::rip's opinion of the best value for it ;)

A suggested change for better accuracy; instead of:

+    my $source_aspect = $width/$height;
+    my $target_aspect = $self->aspect_ratio;
+    my ($w, $h) = split(":", $target_aspect);
+    $target_aspect = $w/$h;
+
+    my $export_par = sprintf("%d,100", 100 * $target_aspect / 
$source_aspect);

I'd suggest:

  my ($target_w, $target_h) = split(":", $self->aspect_ratio);
  my $export_par = sprintf("%d,%d",
    $target_w * $height, $target_h * $width);

- Marc